Search paginations #1646
Merged
Search paginations #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredkingham Assigning this to you - if we want it can we fix the test (query count - I hate that test) and merge? We should then perhaps look at moving this wholesale into Opal v0.13 ? |
|
@davidmiller I'll fix this then make a ticket to move this to v0.13.0 |
fredkingham
force-pushed
the
search-paginations
branch
from
05922db
to
98e3f98
Compare
fredkingham
force-pushed
the
search-paginations
branch
from
98e3f98
to
749a6c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs openhealthcare/opal#1565 and openhealthcare/opal#1557
and fixes them for elcid only.
Rather than translating everything into patient summaries and then cutting the data into chunks of 10, we take all patients, order them by -max_episode_id.
Then we get all of the information we want via django annotations. I've yet to be able to make searches last 20 seconds.
I'm fairly sure we could get it a lot quicker by looking at how we do the cut in
_episodes_without_restrictionsbut that would be a different pull request and is probably not required at this time.